The optical constants of many metals commonly used in solar cells, e.g. as contacts or for light trapping structures, are not documented consistently in the literature, with different sources giving different values. In the case of metallic structures designed to improve absorption in a solar cell junction, the use of data from different sources can give strongly varying results for the effectiveness of nanophotonic light-trapping structures. The trade-off between diffraction into more oblique orders in the junction, enhancing absorption in the photovoltaic material, and the number of photons absorbed parasitically in the metal means small differences in the optical constants can lead to different very conclusions about the EQE and J SC . This work documents the different optical constants for silver, aluminium, gold and titanium from several sources, the effect this has on plasmon quality factors, and quantifies the effect on modelling outcomes by considering the optimization of a test structure using a grid of metal nanodisks on the front surface of a thinned-down GaAs cell. Finally, we consider the effect for a structure previously predicted to give a very high J SC for a solar cell with an ultra-thin GaAs layer.